Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to override PluginDownloadURL if it is explicitly set on a plugin #16058

Open
zbuchheit opened this issue Apr 25, 2024 · 0 comments
Labels
area/plugins Plugin acquisition and resolution customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs kind/enhancement Improvements or new features

Comments

@zbuchheit
Copy link

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Today, you can use pluginDownloadURLOverrides to override plugins that don't have PluginDownloadURL explicitly set which is all Pulumi maintained plugins. The only problem is when attempting to use a plugin that does have PluginDownloadURL set, for example, one of the PulumiVerse plugins. In this case there is no way to override it today.

The use case is to be able to configure all plugins to be downloaded from an internally hosted solution such as Artifactory. I will open a separate issue requesting the add of a Artifactory source as well.

Affected area/feature

Plugin Discovery and Sourcing

Additional Context

It likely requires a change in PluginSpec.GetSource here but not sure if there will be some additional work needed to override the URL and get it working correctly to construct a download url root for a internal hosted solution but that is speculative.

@zbuchheit zbuchheit added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team customer/feedback Feedback from customers area/plugins Plugin acquisition and resolution customer/lighthouse Lighthouse customer bugs labels Apr 25, 2024
@justinvp justinvp removed the needs-triage Needs attention from the triage team label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins Plugin acquisition and resolution customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants