Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few extra "additionalProperties": false #11693

Merged
merged 1 commit into from Dec 21, 2022
Merged

Add a few extra "additionalProperties": false #11693

merged 1 commit into from Dec 21, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Dec 20, 2022

Places where the binder doesn't expect anything else.

Fixes the "config" schema. The Go struct is declared as:

Required []string `json:"defaults,omitempty" yaml:"defaults,omitempty"`

But the schema said "required" not "defaults"

@Frassle Frassle requested a review from iwahbe December 20, 2022 09:11
@Frassle Frassle changed the title The binder doesn't expect anything apart from moduleFormat in meta Add a few extra "additionalProperties": false Dec 20, 2022
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Dec 20, 2022

Changelog

[uncommitted] (2022-12-21)

@Frassle Frassle force-pushed the fraser/fixSchema branch 3 times, most recently from 1746c23 to c6c3786 Compare December 20, 2022 10:01
@Frassle Frassle added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Dec 20, 2022
@iwahbe
Copy link
Member

iwahbe commented Dec 20, 2022

I think we violate this new constraint during tests.

@Frassle
Copy link
Member Author

Frassle commented Dec 20, 2022

Yeh, I'll have a dig around tomorrow see what's tripping this up.

@Frassle Frassle force-pushed the fraser/fixSchema branch 3 times, most recently from b51e27d to 8e268bc Compare December 20, 2022 23:13
Places where the binder doesn't expect anything else.
@Frassle
Copy link
Member Author

Frassle commented Dec 21, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

Build succeeded:

@bors bors bot merged commit 0450a10 into master Dec 21, 2022
@bors bors bot deleted the fraser/fixSchema branch December 21, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants