New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty print PCL types in error messages #11676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
added
area/codegen
SDK-gen, program-gen, convert
kind/engineering
Work that is not visible to an external user
labels
Dec 19, 2022
iwahbe
force-pushed
the
iwahbe/pretty-print-pcl-types
branch
from
December 19, 2022 13:17
c616950
to
2257a45
Compare
Changelog[uncommitted] (2022-12-19) |
iwahbe
added
the
impact/no-changelog-required
This issue doesn't require a CHANGELOG update
label
Dec 19, 2022
iwahbe
changed the title
Pretty print PCL types
Pretty print PCL types in error messages
Dec 19, 2022
iwahbe
force-pushed
the
iwahbe/pretty-print-pcl-types
branch
2 times, most recently
from
December 19, 2022 13:59
cd12c7d
to
f4bb1eb
Compare
kpitzen
reviewed
Dec 19, 2022
This is part of an effort to make PCL type error messages better.
iwahbe
force-pushed
the
iwahbe/pretty-print-pcl-types
branch
from
December 19, 2022 16:13
f4bb1eb
to
9109607
Compare
aq17
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏼
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/codegen
SDK-gen, program-gen, convert
impact/no-changelog-required
This issue doesn't require a CHANGELOG update
kind/engineering
Work that is not visible to an external user
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how type errors are printed, adding multi-line pretty printing to types. It is part of an effort to make PCL type error messages better (#11573).
For comparison, here is the same error message with and without this PR:
Before:
After: