Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move over some env vars to the new lib #11662

Merged
merged 1 commit into from Dec 21, 2022
Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 15, 2022

This is one of many PRs to port our environmental variable usage over to the new library.

I modified cmdutil.Table to allow printing multi-line rows to allow vars to have multi-line documentation.

I modified cmdutil.Table to allow printing multi-line rows to allow vars
to have multi-line documentation.
@iwahbe iwahbe requested review from dixler and aq17 December 15, 2022 15:16
@iwahbe iwahbe self-assigned this Dec 15, 2022
@iwahbe iwahbe added impact/no-changelog-required This issue doesn't require a CHANGELOG update kind/engineering Work that is not visible to an external user labels Dec 15, 2022
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-12-15)

Copy link
Contributor

@aq17 aq17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iwahbe
Copy link
Member Author

iwahbe commented Dec 21, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

Build succeeded:

@bors bors bot merged commit 2fde3ef into master Dec 21, 2022
@bors bors bot deleted the iwahbe/move-over-env-vars branch December 21, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update kind/engineering Work that is not visible to an external user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants