Don't use *schema.Package in nodejs codegen
#11589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
added
language/javascript
impact/no-changelog-required
Changelog[uncommitted] (2022-12-08) |
Zaid-Ajaj
approved these changes
Dec 8, 2022
RobbieMcKinstry
approved these changes
Dec 8, 2022
iwahbe
force-pushed
the
iwahbe/nodejs-ref-only
branch
from
b59bbcd
to
5e9bda0
Compare
|
bors r+ |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors bot
added a commit
that referenced
this pull request
Dec 8, 2022
11589: Don't use `*schema.Package` in nodejs codegen r=iwahbe a=iwahbe Part of #9932 Builds on #11578 tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed. 11592: Don't use `*schema.Package` in .NET codegen r=iwahbe a=iwahbe Part of #9932 Builds on #11578 tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed. 11593: Interpret schema.Asset as pcl.AssetOrArchive r=iwahbe a=iwahbe Fixes #11572 Co-authored-by: Ian Wahbe <ian@wahbe.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Dec 8, 2022
11559: fix(sdk/python): Allow for duplicate output values in python programs r=kpitzen a=kpitzen I used the node SDK as inspiration for this change - there were a few things we were doing differently in python (specifically handling all cases in the outer layer of `massage` rather than allowing for more fine-grained control in a `massage_complex` function like in node. We also take the stack concept from the node SDK to resolve the immediate issue of duplicate outputs. <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #11133 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 11588: Don't use *schema.Package in go codegen r=iwahbe a=iwahbe Part of #9932 Builds on #11578 tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed. 11589: Don't use `*schema.Package` in nodejs codegen r=iwahbe a=iwahbe Part of #9932 Builds on #11578 tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed. Co-authored-by: Kyle Pitzen <kylepitzen@Kyles-MBP.fios-router.home> Co-authored-by: Ian Wahbe <ian@wahbe.com>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9932
Builds on #11578
tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed.