Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen regression in Pulumi YAML #11571

Closed
AaronFriel opened this issue Dec 7, 2022 · 4 comments
Closed

Codegen regression in Pulumi YAML #11571

AaronFriel opened this issue Dec 7, 2022 · 4 comments
Assignees
@iwahbe
Labels
area/codegen SDK-gen, program-gen, convert impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 Bugs severe enough to be the next item assigned to an engineer resolution/by-design This issue won't be fixed because the functionality is working as designed
Milestone
0.82

Comments

@AaronFriel
Copy link
Member

Updating Pulumi YAML to reference the most recent build of Pulumi (commit fbaf685) results in test failures in Pulumi YAML:

=== CONT  TestGenerateExamples/aws-static-website
    /home/friel/c/github.com/pulumi/pulumi-yaml/pkg/tests/example_transpile_test.go:122:
        	Error Trace:	/home/friel/c/github.com/pulumi/pulumi-yaml/pkg/tests/example_transpile_test.go:122
        	Error:      	Should be false
        	Test:       	TestGenerateExamples/aws-static-website
        	Messages:   	aws-static-website.pp:9,11-21: cannot assign expression of type object(
  # This error was very, very, very long.

=== CONT  TestGenerateExamples/azure-container-apps
    /home/friel/c/github.com/pulumi/pulumi-yaml/pkg/tests/example_transpile_test.go:122:
        	Error Trace:	/home/friel/c/github.com/pulumi/pulumi-yaml/pkg/tests/example_transpile_test.go:122
        	Error:      	Should be false
        	Test:       	TestGenerateExamples/azure-container-apps
        	Messages:   	azure-container-apps.pp:37,2-17: unsupported attribute 'environmentType'; unsupported attribute 'environmentType'
=== CONT  TestGenerateExamples/azure-app-service
    /home/friel/c/github.com/pulumi/pulumi-yaml/pkg/tests/example_transpile_test.go:122:
        	Error Trace:	/home/friel/c/github.com/pulumi/pulumi-yaml/pkg/tests/example_transpile_test.go:122
        	Error:      	Should be false
        	Test:       	TestGenerateExamples/azure-app-service
        	Messages:   	azure-app-service.pp:56,11-31: cannot assign expression of type Archive to location of type union(Asset, none, output(Asset), annotated(0xc0004fcf80)): ;
@AaronFriel AaronFriel added kind/bug Some behavior is incorrect or out of spec p1 Bugs severe enough to be the next item assigned to an engineer area/codegen SDK-gen, program-gen, convert impact/regression Something that used to work, but is now broken labels Dec 7, 2022
@AaronFriel
Copy link
Member Author

AaronFriel commented Dec 7, 2022 •
edited

Introduced in #11371. It looks like we need to disable some binder resource type checking in Pulumi YAML, but I'll leave this open for @iwahbe to assess. If we're encountering these errors in YAML, would we see the same thing with tf2pulumi?

@iwahbe iwahbe self-assigned this Dec 7, 2022
@iwahbe iwahbe added this to the 0.82 milestone Dec 7, 2022
@iwahbe iwahbe mentioned this issue Dec 7, 2022
Merged
@iwahbe
Copy link
Member

iwahbe commented Dec 7, 2022

I opened #11573 as follow up for # This error was very, very, very long.

@iwahbe
Copy link
Member

iwahbe commented Dec 7, 2022

There is an existing option, pcl.SkipResourceTypechecking, to opt out of these error messages. tf2pulumi has this option set in all cases. It won't be effected.

@iwahbe iwahbe added the resolution/by-design This issue won't be fixed because the functionality is working as designed label Dec 7, 2022
@iwahbe
Copy link
Member

iwahbe commented Dec 7, 2022

I think everything is working as intended here. I have a PR in pulumi-yaml to bump the pu/pu dependency and disable the errors when necessary: pulumi/pulumi-yaml#424.

@iwahbe iwahbe closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
area/codegen SDK-gen, program-gen, convert impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 Bugs severe enough to be the next item assigned to an engineer resolution/by-design This issue won't be fixed because the functionality is working as designed
Projects
None yet
Milestone
0.82
Development

No branches or pull requests
2 participants
@AaronFriel @iwahbe