Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codegen/node] Remove empty types files #11561

Open
RobbieMcKinstry opened this issue Dec 6, 2022 · 0 comments
Open

[codegen/node] Remove empty types files #11561

RobbieMcKinstry opened this issue Dec 6, 2022 · 0 comments
Labels
area/codegen SDK-gen, program-gen, convert impact/performance Something is slower than expected kind/engineering Work that is not visible to an external user language/javascript size/M Estimated effort to complete (up to 5 days).

Comments

@RobbieMcKinstry
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

When reviewing #10831, @t0yv0 noticed namespaces with no types emit as empty files. In particular, here are the optimizations we intend:

  1. Leaf namespaces with no types should not emit types files (/types/<leaf>/{input, output}.ts) when there aren't any types defined in those files. I.e. if input.ts is empty, it should be removed. If output.ts is empty, it should be removed.
  2. Internal namespaces with no types in either input.ts or output.ts should be removed.

This improvement will eliminate 3005 files from Azure Native (improving performance by reducing total work).

Affected area/feature

@RobbieMcKinstry RobbieMcKinstry added impact/performance Something is slower than expected language/javascript area/codegen SDK-gen, program-gen, convert kind/engineering Work that is not visible to an external user size/M Estimated effort to complete (up to 5 days). labels Dec 6, 2022
@RobbieMcKinstry RobbieMcKinstry added this to the 0.83 milestone Dec 6, 2022
@mikhailshilkov mikhailshilkov removed this from the 0.83 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen SDK-gen, program-gen, convert impact/performance Something is slower than expected kind/engineering Work that is not visible to an external user language/javascript size/M Estimated effort to complete (up to 5 days).
Projects
None yet
Development

No branches or pull requests

2 participants