Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codegen/node] Replace "@/" paths with their relative counterparts. #11560

Open
RobbieMcKinstry opened this issue Dec 6, 2022 · 0 comments
Open

[codegen/node] Replace "@/" paths with their relative counterparts. #11560

RobbieMcKinstry opened this issue Dec 6, 2022 · 0 comments
Labels
area/codegen SDK-gen, program-gen, convert impact/performance Something is slower than expected kind/engineering Work that is not visible to an external user language/javascript size/M Estimated effort to complete (up to 5 days).

Comments

@RobbieMcKinstry
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

This issue is to edit the NodeJS type splitting implementation (#10831) to forgo "@/" paths in place of relative imports. Initially, I chose to go with absolute paths because they are 100x easer to read and implement. I encountered a few bugs in codegen which limited my ability to sanely use relative imports in the past. I'm hoping to make a few refactors that make it simpler to implement the relative paths.

Unfortunately, the source of this issue is a bug in TSC which won't be fixed any time soon. As a result, paths configuration in tsc is unusable in library code.

Affected area/feature

Nodejs codegen
@RobbieMcKinstry RobbieMcKinstry added impact/performance Something is slower than expected language/javascript area/codegen SDK-gen, program-gen, convert kind/engineering Work that is not visible to an external user size/M Estimated effort to complete (up to 5 days). labels Dec 6, 2022
@RobbieMcKinstry RobbieMcKinstry added this to the 0.82 milestone Dec 6, 2022
@RobbieMcKinstry RobbieMcKinstry self-assigned this Dec 6, 2022
@RobbieMcKinstry RobbieMcKinstry mentioned this issue Dec 6, 2022
Open
6 tasks
RobbieMcKinstry added a commit that referenced this issue Dec 7, 2022
@RobbieMcKinstry
Reintroduce type splitting in NodeJS codegen.
40abc84 
This commit reintroduces the changes that were reverted
in #11534. This time,
we hide the feature behind language-specific config in the schema,
and default it to off.

At this time, providers should not enable the feature until
#11560 has been addressed.
RobbieMcKinstry added a commit that referenced this issue Dec 7, 2022
@RobbieMcKinstry
Reintroduce type splitting in NodeJS codegen.
ecf6f78 
This commit reintroduces the changes that were reverted
in #11534. This time,
we hide the feature behind language-specific config in the schema,
and default it to off.

At this time, providers should not enable the feature until
#11560 has been addressed.
@RobbieMcKinstry RobbieMcKinstry mentioned this issue Dec 7, 2022
Draft
3 tasks
@lukehoban lukehoban modified the milestones: 0.82, 0.83 Jan 13, 2023
@RobbieMcKinstry RobbieMcKinstry modified the milestones: 0.83, 0.85 Jan 17, 2023
@RobbieMcKinstry RobbieMcKinstry removed this from the 0.85 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/codegen SDK-gen, program-gen, convert impact/performance Something is slower than expected kind/engineering Work that is not visible to an external user language/javascript size/M Estimated effort to complete (up to 5 days).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukehoban @RobbieMcKinstry