Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk/python): Allow for duplicate output values in python programs #11559

Merged
merged 1 commit into from Dec 8, 2022

Conversation

kpitzen
Copy link
Contributor

@kpitzen kpitzen commented Dec 6, 2022

I used the node SDK as inspiration for this change - there were a few things we were doing differently in python (specifically handling all cases in the outer layer of massage rather than allowing for more fine-grained control in a massage_complex function like in node. We also take the stack concept from the node SDK to resolve the immediate issue of duplicate outputs.

Description

Fixes #11133

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Dec 6, 2022

Changelog

[uncommitted] (2022-12-07)

Bug Fixes

  • [sdk/python] Allows for duplicate output values in python
    #11559

@kpitzen kpitzen force-pushed the KP/11133 branch 3 times, most recently from c38f344 to a1db2c6 Compare December 6, 2022 23:46
sdk/python/.gitignore Show resolved Hide resolved
sdk/python/lib/pulumi/runtime/stack.py Show resolved Hide resolved
sdk/python/lib/test/langhost/stack_output/__main__.py Outdated Show resolved Hide resolved
I used the node SDK as inspiration for this change - there were a few things
we were doing differently in python (specifically handling all cases in
the outer layer of `massage` rather than allowing for more fine-grained
control in a `massage_complex` function like in node.  We also take the stack
concept from the node SDK to resolve the immediate issue of duplicate outputs.
@kpitzen
Copy link
Contributor Author

kpitzen commented Dec 8, 2022

bors r+

bors bot added a commit that referenced this pull request Dec 8, 2022
11559: fix(sdk/python): Allow for duplicate output values in python programs r=kpitzen a=kpitzen

I used the node SDK as inspiration for this change - there were a few things we were doing differently in python (specifically handling all cases in the outer layer of `massage` rather than allowing for more fine-grained control in a `massage_complex` function like in node.  We also take the stack concept from the node SDK to resolve the immediate issue of duplicate outputs.

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Fixes #11133 

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [x] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


11588: Don't use *schema.Package in go codegen r=iwahbe a=iwahbe

Part of #9932
Builds on #11578

tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed.

11589: Don't use `*schema.Package` in nodejs codegen r=iwahbe a=iwahbe

Part of #9932
Builds on #11578

tldr: Package is not reliable when its used for an external package. We are transferring over to PackageReference, and will remove the Package field once all references to it have been removed.

Co-authored-by: Kyle Pitzen <kylepitzen@Kyles-MBP.fios-router.home>
Co-authored-by: Ian Wahbe <ian@wahbe.com>
@bors
Copy link
Contributor

bors bot commented Dec 8, 2022

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Dec 8, 2022

Build succeeded:

@bors bors bot merged commit f43f549 into master Dec 8, 2022
@bors bors bot deleted the KP/11133 branch December 8, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate outputs not supported
3 participants