Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codegen/node] Add config to enable type splitting #11557

Open
RobbieMcKinstry opened this issue Dec 6, 2022 · 0 comments 路 May be fixed by #11579
Open

[codegen/node] Add config to enable type splitting #11557

RobbieMcKinstry opened this issue Dec 6, 2022 · 0 comments 路 May be fixed by #11579
Labels
area/codegen SDK-gen, program-gen, convert area/sdks Pulumi language SDKs kind/engineering Work that is not visible to an external user

Comments

@RobbieMcKinstry
Copy link
Contributor

RobbieMcKinstry commented Dec 6, 2022

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Splitting NodeJS types files into smaller units created two P0 issues.

To guard against this, we would like to add a toggle to enable this feature in the SDK schema. This feature is to add the old behavior back in, but guard against it with a schema toggle.

This will allow us to continue to iterate on the existing work without disrupting providers. It will also allow providers to opt into this feature in the future at their leisure.

The toggle will default to "off".

Affected area/feature

codegen/nodejs

@RobbieMcKinstry RobbieMcKinstry added area/sdks Pulumi language SDKs area/codegen SDK-gen, program-gen, convert kind/engineering Work that is not visible to an external user labels Dec 6, 2022
@RobbieMcKinstry RobbieMcKinstry added this to the 0.82 milestone Dec 6, 2022
@lukehoban lukehoban modified the milestones: 0.82, 0.83 Jan 13, 2023
@justinvp justinvp modified the milestones: 0.83, 0.84 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen SDK-gen, program-gen, convert area/sdks Pulumi language SDKs kind/engineering Work that is not visible to an external user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants