Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use preview plans for --yes in experimental mode #11445

Merged
merged 1 commit into from Nov 23, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Nov 23, 2022

Description

Fixes #11444

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Nov 23, 2022

Changelog

[uncommitted] (2022-11-23)

Bug Fixes

  • [cli] up --yes should not use update plans.
    #11445

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add any tests for this?

@Frassle
Copy link
Member Author

Frassle commented Nov 23, 2022

Can we add any tests for this?

Not really, this stuff is annoyingly deep in the engine which is not very testable.

@Frassle
Copy link
Member Author

Frassle commented Nov 23, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 23, 2022

Build succeeded:

@bors bors bot merged commit 355e07d into master Nov 23, 2022
@bors bors bot deleted the fraser/previewPlanYes branch November 23, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulumi up --yes failing with 3.47.2 due to error: resource violates plan
3 participants