Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit missing var errors for const vars #11426

Merged
merged 1 commit into from Nov 23, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 22, 2022

Fixes #11372

We test that consts behave correctly by omitting them from an example
and assigning from the omitted value.
@iwahbe iwahbe self-assigned this Nov 22, 2022
@iwahbe iwahbe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 22, 2022
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-11-22)

@iwahbe iwahbe requested a review from aq17 November 22, 2022 22:25
Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zaid-Ajaj
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 23, 2022

Build succeeded:

@bors bors bot merged commit 534847d into master Nov 23, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/11372/pcl-type-check-const branch November 23, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCL type check doesn't account for const attributes
3 participants