Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCL type check doesn't account for const attributes #11372

Closed
iwahbe opened this issue Nov 16, 2022 · 0 comments · Fixed by #11426
Closed

PCL type check doesn't account for const attributes #11372

iwahbe opened this issue Nov 16, 2022 · 0 comments · Fixed by #11426
Assignees
Labels
area/codegen SDK-gen, program-gen, convert kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@iwahbe
Copy link
Member

iwahbe commented Nov 16, 2022

What happened?

The PCL binder raises missing required attribute errors on const attributes.

Steps to reproduce

Remove the bind option added in #11371 and then run

go test --run=TestGenerateProgram/transpiled_examples/kubernetes ./...

Expected Behavior

Const attributes shouldn't need to be present.

Actual Behavior

Error on missing const attributes.

Output of pulumi about

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec area/codegen SDK-gen, program-gen, convert labels Nov 16, 2022
@iwahbe iwahbe self-assigned this Nov 16, 2022
@iwahbe iwahbe added this to the 0.81 milestone Nov 16, 2022
@bors bors bot closed this as completed in 534847d Nov 23, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen SDK-gen, program-gen, convert kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants