Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a new markdown representation of example conversion failures #619

Merged
merged 9 commits into from Dec 6, 2022
Merged

Adds a new markdown representation of example conversion failures #619

merged 9 commits into from Dec 6, 2022

Conversation

dixler
Copy link
Contributor

@dixler dixler commented Oct 5, 2022 •
edited

Provides a human-friendly markdown version of translation errors.

context: https://github.com/pulumi/home/issues/2344

part of https://github.com/pulumi/home/issues/2462

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Diff for pulumi-random with merge commit 328fa7f

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Diff for pulumi-azuread with merge commit 328fa7f

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Diff for pulumi-gcp with merge commit 328fa7f

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Diff for pulumi-azure with merge commit 328fa7f

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Diff for pulumi-aws with merge commit 328fa7f

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-random with merge commit c67fb49

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-azuread with merge commit c67fb49

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-gcp with merge commit c67fb49

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-azure with merge commit c67fb49

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-random with merge commit 07b4f89

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-azuread with merge commit 07b4f89

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-random with merge commit 28e8dba

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-azuread with merge commit 28e8dba

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-gcp with merge commit 07b4f89

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-gcp with merge commit 28e8dba

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-azure with merge commit 07b4f89

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-azure with merge commit 28e8dba

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-aws with merge commit c67fb49

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-aws with merge commit 07b4f89

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Diff for pulumi-aws with merge commit 28e8dba

@dixler dixler marked this pull request as ready for review December 5, 2022 22:51
dixler
dixler commented Dec 6, 2022
View reviewed changes
pkg/tfgen/docs.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Diff for pulumi-random with merge commit 30afc95

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Diff for pulumi-azuread with merge commit 30afc95

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Diff for pulumi-gcp with merge commit 30afc95

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Diff for pulumi-azure with merge commit 30afc95

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Diff for pulumi-aws with merge commit 30afc95

@dixler dixler requested review from thomas11 and aq17 December 6, 2022 17:46
aq17
aq17 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@aq17 aq17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

thomas11
thomas11 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a ton of context but LGTM!

@dixler dixler merged commit 7a6a993 into master Dec 6, 2022
@dixler dixler deleted the dixler/error-example-diagnostics branch December 6, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas11 thomas11 thomas11 approved these changes

@aq17 aq17 aq17 approved these changes

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dixler @thomas11 @aq17