npm install runs all the time

[v-yarotsky]

What happened?

I have pulumi-kubernetes-operator managing 4 stacks from 2 TypeScript programs (fetched from git).
Even if there are no changes to the git repo, the pod keeps continuously running npm install
This does not seem desirable.

Example

All screenshots were taken around the same time.

I have the following dependencies in my package.json in the root of the repo where the pulumi programs reside:

...
    "@pulumi/keycloak": "^5.2.1",
    "@pulumi/kubernetes": "^4.5.2",
    "@pulumi/pulumi": "3.91",
...    

Output of pulumi about

Probably not relevant for this case;
I'm using version 0.5.0 via the Helm chart.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[mjeffryes]

Thanks for filing the report @v-yarotsky. Have you checked if the issue reproduces on a fresh cluster? It might also be interesting to try to run a manual preview for the stacks to see if there is and to check the interval for the reconcile loop.

[v-yarotsky]

After taking a brief look at the code, it seems like this is by design.
On each iteration of the Reconcile loop¹, reconcileStackSession.setupWorkspace² is called, which in turn calls reconcileStackSession.InstallProjectDependencies³. All of that is happening before checking whether the current commit matches the last applied one⁴.

Footnotes

1. https://github.com/pulumi/pulumi-kubernetes-operator/blob/758a51441e9537133fe8bf7df28e7183ef057a54/pkg/controller/stack/stack_controller.go#L635 ↩

2. https://github.com/pulumi/pulumi-kubernetes-operator/blob/758a51441e9537133fe8bf7df28e7183ef057a54/pkg/controller/stack/stack_controller.go#L1392 ↩

3. https://github.com/pulumi/pulumi-kubernetes-operator/blob/758a51441e9537133fe8bf7df28e7183ef057a54/pkg/controller/stack/stack_controller.go#L1490 ↩

4. https://github.com/pulumi/pulumi-kubernetes-operator/blob/758a51441e9537133fe8bf7df28e7183ef057a54/pkg/controller/stack/stack_controller.go#L783 ↩