Support custom name for serviceAccount in helm chart

[kerruba-milkman]

Hello!

• Vote on this issue by adding a 👍 reaction
• If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently the helm chart uses the helper pulumi-kubernetes-operator.fullname to populate the service account name, but the values.yaml file provide a serviceAccount.name value that is only used if the serviceAccount.create is false.

Could make sense to use the serviceAccount.name field as .metadata.name in the ServiceAccount and fallback to the fullname only if the serviceAccount.name field is empty or missing.

Having to use the fullnameOverride value to override the name of the serviceAccount doesn't provide enought flexibility and it could be confusing having both serviceAccount.create = true and serviceAccount.name = "non-empty-string".

[mjeffryes]

Thanks for reporting this @kerruba-milkman, I'll add it to our backlog.