Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PreserveWorkingDirectory flag #522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add PreserveWorkingDirectory flag #522

wants to merge 2 commits into from

Conversation

bacek
Copy link

@bacek bacek commented Nov 9, 2023

Proposed changes

Optionally preserve working directory between reconciliations.

Related issues (optional)

Fixes #521

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@rquitales
Copy link
Contributor

/run-acceptance-tests

@github-actions GitHub Actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes-operator/actions/runs/6857610177

mjeffryes
mjeffryes reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mjeffryes mjeffryes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @bacek! The code change looks reasonable. Could you please add a test that exercises the PreserveWorkingDirectory option? And add an entry to the changelog? I think that's all that's needed to land this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjeffryes mjeffryes mjeffryes left review comments

@EronWright EronWright Awaiting requested review from EronWright

@rquitales rquitales Awaiting requested review from rquitales

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide ability to preserve working directory.
3 participants
@bacek @rquitales @mjeffryes