Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing by enabling unit and integration tests #447

Open
1 of 5 tasks
Tracked by #586
rquitales opened this issue May 9, 2023 · 0 comments
Open
1 of 5 tasks
Tracked by #586

Improve testing by enabling unit and integration tests #447

rquitales opened this issue May 9, 2023 · 0 comments
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features

Comments

@rquitales
Copy link
Contributor

rquitales commented May 9, 2023

Currently, we have tests nested under the test folder. These are integration tests that runs a locally built controller binary against the testdata stacks. We also have some unit tests (pending being fixed in #387), but these are unused currently. We should expand on our unit tests by also running them in CI, and encouraging new feature development to also include unit testing, rather than only having integration testing.

Some potential next steps after landing #387:

  • Enable running unit tests by including a Make target
  • Running both integration and unit tests in CI
  • Most of the tests in stack_controller_test.go should be split up so they test one thing at a time
  • Most of the tests in stack_controller_test.go could be rewritten to not need AWS, with the exception of testing S3 bucket as a backend (which could be skipped locally)
  • Potentially running periodic CI tests against an actual Kubernetes cluster
@rquitales rquitales added kind/enhancement Improvements or new features impact/reliability Something that feels unreliable or flaky good-first-issue Start here if you'd like to start contributing to Pulumi labels May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi impact/reliability Something that feels unreliable or flaky kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant