Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build.gradle.kts to Gradle executor detection #1231

Merged
merged 6 commits into from
May 10, 2024

Conversation

josephglanville
Copy link
Contributor

@josephglanville josephglanville commented Oct 3, 2023

Description

Most modern Gradle projects use the Gradle Kotlin DSL.
This change is necessary to detect projects as it's not possible
to add one of the existing filetypes without disrupting the build
configuration, especially in multi-project Gradle builds.

Fixes #846

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

Most modern Gradle projects use the Gradle Kotlin DSL.
This change is necessary to detect projects as it's not possible
to add one of the existing filetypes without disrupting the build
configuration, especially in multi-project Gradle builds.
@josephglanville
Copy link
Contributor Author

@Zaid-Ajaj could you help me get this reviewed?

@mklueh
Copy link

mklueh commented Feb 1, 2024

Can somebody please get this merged?

@justinvp
Copy link
Member

/run-acceptance-tests

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement and for your patience!

@justinvp justinvp merged commit 21fa48b into pulumi:main May 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle executor is not detected if only build.gradle.kts file is present
3 participants