Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flattening if properties would clash #3195

Open
danielrbradley opened this issue Apr 2, 2024 · 0 comments
Open

Skip flattening if properties would clash #3195

danielrbradley opened this issue Apr 2, 2024 · 0 comments
Labels
3.0 impact/accessibility Something that is difficult or impossible for some people to use kind/enhancement Improvements or new features

Comments

@danielrbradley
Copy link
Member

Draft PR: #3016

Skip the flattening of nested properties indicated by x-ms-client-flatten if it would lead to overwriting a property, creating incorrect schema and SDKs. This case happens when inner and outer property have the same name, for a report on all occurrences see #3013.

This change is breaking and could therefore only be applied to v3 of the provider. The purpose of the PR is mainly to illustrate the SDK changes that would result.

Note: remember to remove exception added in #3007.

@danielrbradley danielrbradley added kind/enhancement Improvements or new features impact/accessibility Something that is difficult or impossible for some people to use 3.0 labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 impact/accessibility Something that is difficult or impossible for some people to use kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

1 participant