-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 Resource version listed does not compile #2920
Comments
Hi @hisuwh, I can understand why that diff would seem scary, but it looks like just the outputs are changing; it's probably not due to the different versions of WebApp in v2. If you want to share the full diff and some of the code that creates the You are right about the versions in table in the documentation not being available. You can get the 20201001 version of WebApp in v2 which should be compatible, but again that's probably not the source of the diff you're seeing. |
The thing that scares me is the type is changing. It might not be clear from the cropped screenshot but the Now it seems to be just a string - so how I can be sure that it is going to apply the same values (albeit the diff on config was pretty hard to interpret before).
They do seem to be available just incomplete. |
Again, I think we'll need to seem more of the diff and code to give you a complete answer, but it looks like what you're seeing is the type of the output is changing, not the input to the config. |
@mjeffryes does the code and config above give you more information? |
I have just stood up a brand new stack to verify this does the right thing - which it does seem to do. However, I still think this is a problem that I now can no longer see the diff of my Azure App config. It was unreadable before but this seems a step in the wrong direction. |
Just circling back round on this @hisuwh ... so the actual change went through fine and the rich type is still there? It looks like the only remaining issue is that the diff was more noisy that it should be for this resource - is that correct? Unfortunately it's still very hard to understand what's going on from the screenshots posted. What would be most beneficial here would be:
|
What happened?
I have upgraded
@pulumi/azure-native
to v2 to fix a memory usage issue I was experiencing with Typescript.This is changing my WebApp site config:
This is scary, I'm not sure what the consequences of this are and at the very least I have no visibility of the config being applied.
I have tried switching back to the previous resource versions according to this: https://www.pulumi.com/registry/packages/azure-native/from-v1-to-v2/top-level-resource-versions/
However, this version does not compile with these errors:
Example
Output of
pulumi about
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: