Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pulumi YAML support to perform the conversion #84

Closed
lblackstone opened this issue Nov 16, 2022 · 3 comments
Closed

Use Pulumi YAML support to perform the conversion #84

lblackstone opened this issue Nov 16, 2022 · 3 comments
Labels
kind/enhancement Improvements or new features resolution/wont-fix This issue won't be fixed

Comments

@lblackstone
Copy link
Member

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

kube2pulumi was written before Pulumi YAML was introduced. Pulumi YAML now supports first-class conversion workflows, so it should be possible to rely on those libraries rather than maintaining a separate conversion implementation.

Related: #82

Affected area/feature

@lblackstone lblackstone added the kind/enhancement Improvements or new features label Nov 16, 2022
@lblackstone
Copy link
Member Author

@AaronFriel Curious if you have any thoughts about this? I think the only major difference on the conversion is that kube2pulumi expects k8s manifests directly, whereas Pulumi YAML would nest them under resources with a slightly different shape.

@AaronFriel
Copy link
Member

I'm not sure if it makes sense to use YAML as an intermediate, except that YAML has invested in great error messages.

We've recently integrated tf2pulumi directly into the Pulumi CLI: pulumi/pulumi#11341

If kube2pulumi exported a function to generate PCL from a directory of manifests, that seems like the natural next step. We've been naming this function Eject with a signature:

func Eject(dir string, loader schema.ReferenceLoader) (*workspace.Project, *pcl.Program, error)

@lblackstone
Copy link
Member Author

It sounds like this approach isn't recommended, so I'm going to close this issue. I opened #86 to track the pulumi convert integration story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/wont-fix This issue won't be fixed
Projects
None yet
Development

No branches or pull requests

2 participants