Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force immediate downloading of artifacts with a checksum weaker than sha256 #3315

Open
dralley opened this issue Nov 16, 2023 · 0 comments
Open
Labels

Comments

@dralley
Copy link
Contributor

dralley commented Nov 16, 2023

We have to support syncing these repos (for now), but we don't have to support on-demand sync. As part of phasing these checksums out forever, we should remove deferred download support for them.

The justifications are as follows:

  • On-demand artifacts use whichever checksum they have as an identifier. If that checksum is a weak checksum with known propensity for collisions, then it is theoretically possible to end up with the wrong (more plausibly - a maliciously constructed) artifact being downloaded
  • It enables future moves like Phase out all checksums weaker than sha256 (if possible) pulpcore#4726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant