Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML has higher priority than block quotes #674

Closed
notriddle opened this issue Jun 22, 2023 · 3 comments · Fixed by #675
Closed

HTML has higher priority than block quotes #674

notriddle opened this issue Jun 22, 2023 · 3 comments · Fixed by #675

Comments

@notriddle
Copy link
Collaborator

Found with modified differential fuzzer (please mark as a fuzzing output): #673

Events from pulldown-cmark:

"<G\n>\n" -> [
  Start(Paragraph)
    Html(Boxed("<G\n>"))
  End(Paragraph)
]

Events from pandoc:

"<G\n>\n" -> [
  Start(Paragraph)
    Text(Boxed("<G"))
  End(Paragraph)
  Start(BlockQuote)
  End(BlockQuote)
]

Events from commonmark.js:

"<G\n>\n" -> [
  Start(Paragraph)
    Text(Boxed("<G"))
  End(Paragraph)
  Start(BlockQuote)
  End(BlockQuote)
]

AST from pandoc:

Pandoc {
    meta: {},
    blocks: [
        Para(
            [
                Str(
                    "<G",
                ),
            ],
        ),
        BlockQuote(
            [],
        ),
    ],
}
@notriddle
Copy link
Collaborator Author

Regression test filed against commonmark: commonmark/commonmark-spec#738

@Martin1887
Copy link
Collaborator

I understand the issue here is that only HTML blocks should have higher priority than block quotes meanwhile inline HTML should have less priority, right?

@notriddle
Copy link
Collaborator Author

That seems correct, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants