Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unoptimized events in a special case related with escaping. #591

Open
crlf0710 opened this issue Jun 5, 2022 · 3 comments
Open

Unoptimized events in a special case related with escaping. #591

crlf0710 opened this issue Jun 5, 2022 · 3 comments

Comments

@crlf0710
Copy link

crlf0710 commented Jun 5, 2022

Currently when parsing this:

\***

Three events each with a single char is generated. Isn't it better expressed with one single event?

@marcusklaas
Copy link
Collaborator

Yep, that would be more efficient. I remember experimenting with logic to merge text events, and it was a lot faster for such examples, but it was making the general case a bit slower, so I decided against it.

If it can be done without such a trade-off, I'd be all for it!

@crlf0710
Copy link
Author

crlf0710 commented Jun 5, 2022

I'm not very familiar with the internals of the code yet, i wonder if it is possible for someone to point me to some snippet in charge of this or some existing branch so i can get started hacking and experimenting with it :)

@equt
Copy link
Contributor

equt commented Jun 7, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants