Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we know if the connection is broken? #24

Open
nichoth opened this issue Jan 22, 2019 · 1 comment
Open

Do we know if the connection is broken? #24

nichoth opened this issue Jan 22, 2019 · 1 comment
Labels

Comments

@nichoth
Copy link
Contributor

nichoth commented Jan 22, 2019

Is there something like a heartbeat in pull-ws that will let us know if the network fails? In ws there is a good explanation:

https://www.npmjs.com/package/ws#how-to-detect-and-close-broken-connections

Or if not here, does the normal ssb stack implement this somewhere, like in muxrpc?

Thanks

@dominictarr
Copy link
Member

oh, I didn't know about that!
this module just wraps ws so should be possible. Since it's part of the spec I'd be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants