Skip to content

Remote code execution via the `pretty` option.

High
ForbesLindesay published GHSA-p493-635q-r6gr Feb 28, 2021

Package

npm pug (npm)

Affected versions

<3.0.1

Patched versions

3.0.1

Description

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to pug@3.0.1 or pug-code-gen@3.0.2 or pug-code-gen@2.0.3, which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: #3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy

Severity

High

CVE ID

CVE-2021-21353

Weaknesses

No CWEs