Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dependency status badges in README.md of the child packages" #3146

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Conversation

YasharF
Copy link
Contributor

@YasharF YasharF commented May 29, 2019

For packages in a mono-repo, david-dm.org requires a query parameter that identifies the location of the package.json.

@YasharF YasharF changed the title Fix the dependency status badges in README.MD of the child packages" Fix the dependency status badges in README.md of the child packages" May 29, 2019
@YasharF
Copy link
Contributor Author

YasharF commented May 29, 2019

With the move to the mono-repo, for ease of housekeeping, it might help to add a section to the top-level readme.md which has all of these badges. I can add that as well as part of this PR or as a separate PR.

@YasharF
Copy link
Contributor Author

YasharF commented May 29, 2019

Not in this PR at this point, but I can add the following table to the Readme.md in the root of the monorepo. Let me know if you want it to be right after the current badges, or in a different part of the page.

Dependency Status

Package Dependencies Dev Dependencies
mono-repo top Dependency Status devDependencies Status
pug Dependencies Status Dependencies Status
pug-attrs Dependencies Status Dependencies Status
pug-code-gen Dependencies Status Dependencies Status
pug-error Dependencies Status Dependencies Status
pug-filters Dependencies Status Dependencies Status
pug-lexer Dependencies Status Dependencies Status
pug-linker Dependencies Status Dependencies Status
pug-load Dependencies Status Dependencies Status
pug-parser Dependencies Status Dependencies Status
pug-runtime Dependencies Status Dependencies Status
pug-strip-comments Dependencies Status Dependencies Status
pug-error Dependencies Status Dependencies Status

@ForbesLindesay
Copy link
Member

All of them seem to just say "pending" at the moment. I'm happy to merge, but not if all the badges are just pending anyway.

@YasharF
Copy link
Contributor Author

YasharF commented Jun 3, 2019

From what I have gathered david-dm has a queue, and if a badge hasn't been loaded for a while it loses its data and needs to regenerate the badge. 10 minutes after your comments the above post looked like the first picture below which is probably what you saw, and after another 5 minutes, they looked like the 2nd picture. I suspect once these are in a page like readme.md they will get enough hits that they will be loading all of the time.

At 8:28 PDT
image

At 8:33 PDT
image

Add dependency status from all of the monorepo children to the top level readme.md
@ForbesLindesay ForbesLindesay merged commit 8fcf81d into pugjs:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants