Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start server with errors #129

Open
jiangyh1024 opened this issue Dec 11, 2020 · 5 comments
Open

start server with errors #129

jiangyh1024 opened this issue Dec 11, 2020 · 5 comments
Labels

Comments

@jiangyh1024
Copy link

image

not sure why

@ezhlobo
Copy link
Member

ezhlobo commented Dec 12, 2020

@jiangyh1024 yeah, I've just upgraded to the latest react-scripts and got the same issue. When I added DISABLE_NEW_JSX_TRANSFORM=true it started working for a while but then died again with absolutely the same issue.

I'm investigating right now

@ezhlobo
Copy link
Member

ezhlobo commented Dec 12, 2020

JFYI, I reproduced the issue after upgrading all the dependencies.

Assuming we need to drop node 6 and 8 support and upgrade major version of this plugin, I believe this fix should be coupled with that release, thus it's fine to upgrade internal dependencies here.

@ezhlobo ezhlobo added the bug label Dec 13, 2020
@ezhlobo
Copy link
Member

ezhlobo commented Dec 13, 2020

Well, it turned out to be an issue in babel itself. Look at the issue and related PR: babel/babel#12478

I think we should wait for new patch version of babel plugins, but in the meantime you can just specify older version of @babel/plugin-transform-react-jsx.

This is what I did for my project:

"devDependencies": {
  "@babel/plugin-transform-react-jsx": ">= 7.12 < 7.12.10 || > 7.12.10"
}

CC @jiangyh1024

@jiangyh1024
Copy link
Author

jiangyh1024 commented Dec 13, 2020 via email

@skotchpine
Copy link

the babel issue looks resolved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants