Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests failing don't fail the GA check #136

Open
jywarren opened this issue Nov 2, 2021 · 0 comments · May be fixed by #140
Open

tests failing don't fail the GA check #136

jywarren opened this issue Nov 2, 2021 · 0 comments · May be fixed by #140

Comments

@jywarren
Copy link
Member

jywarren commented Nov 2, 2021

https://github.com/publiclab/mapknitter-exporter-sinatra/runs/4081483476?check_suite_focus=true

Run bundle exec rspec
Warning: NING] Unrecognized arguments: google_storage_access_key_id, google_storage_secret_access_key, persistent
..

Finished in 0.49118 seconds (files took 0.41009 seconds to load)
2 examples, 0 failures

/home/runner/work/mapknitter-exporter-sinatra/mapknitter-exporter-sinatra/lib/export.rb:74:in `save': undefined method `files' for nil:NilClass (NoMethodError)
	from /home/runner/work/mapknitter-exporter-sinatra/mapknitter-exporter-sinatra/vendor/bundle/ruby/2.4.0/gems/mapknitter-exporter-1.0.9/lib/mapknitterExporter.rb:329:in `run_export'
	from /home/runner/work/mapknitter-exporter-sinatra/mapknitter-exporter-sinatra/app/controllers/export_controller.rb:73:in `block in run_export'
@jywarren jywarren linked a pull request Nov 2, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try to make tests fail publiclab/mapknitter-exporter-sinatra
1 participant
@jywarren