Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to merge react-native newer version? #180

Closed
beretboat opened this issue Oct 27, 2017 · 10 comments
Closed

Any plan to merge react-native newer version? #180

beretboat opened this issue Oct 27, 2017 · 10 comments

Comments

@beretboat
Copy link
Collaborator

Last merged react-native version is v44, which use react v16.0.0-alpha.12.
react v16 rc supports fragments (returning arrays from components), a long-expected feature.

@ptmt
Copy link
Owner

ptmt commented Oct 27, 2017

Sure, I do have plans. There a lot of changes such as metro-bundler (decoupled from react-native packager). React 16 Fiber also is very welcomed. I'm waiting for it to stabilize, and before this work I'm upgrading my casual React Native iOS / Android projects.

I guess I can close it since, it's a question.

@ptmt ptmt closed this as completed Oct 27, 2017
@beretboat
Copy link
Collaborator Author

Thanks. Glad to hear.

May I ask when will it happen? In days, weeks, or months? Just a rough estimation, it does not have to be a accurate time.

@ptmt
Copy link
Owner

ptmt commented Oct 27, 2017 via email

@beretboat
Copy link
Collaborator Author

Got it. Thanks!

@beretboat
Copy link
Collaborator Author

Sorry to reopen this. 0.52 has been released for a while, are you still going to merge this version?

@beretboat beretboat reopened this Jan 9, 2018
@ptmt
Copy link
Owner

ptmt commented Jan 9, 2018

Yes. I started it locally. There a lot of changes, including React 16, metro bundler, revised UIExplorer -> TesterApp, moving from Travis to CircleCI, etc. 2661 files to resolve (some of them are quick and straightforward, but a hundred or so are tricky one).

@skellock
Copy link
Contributor

skellock commented Jan 9, 2018

@ptmt Curious if you have a strategy for dealing with this considering you've done this a few times already. Or are you just the most patient man on the planet?

Is something you could use help with or is this a @ptmt shaped problem?

@beretboat
Copy link
Collaborator Author

Good to know, thanks!

@ptmt
Copy link
Owner

ptmt commented Jan 17, 2018

@skellock It's a good question.

I'm working right now on this, it's painfully slow because of a small amount of spare-time. But there are numerous ways to make things faster. First, extract all macOS specific components into the single repo. Something like react-native-appkit-components. The second thing is trying to pull not everything from RN but only specific pull requests (such as upgrading to React 16.2, etc.)

I think also that there are several ongoing projects that may replace this one as more successful.

@ptmt
Copy link
Owner

ptmt commented Jan 17, 2018

This is what it looks like. 2500 merge conflicts to resolve. 50% of them really silly and I usually do this stage fast. The rest usually are Git merge fails, and probably a more sophisticated merger software would help dramatically. I tried most of the free software available for it.

Here are a few examples:
screenshot 2018-01-17 17 26 23
(just need to preserve -macos here).

screenshot 2018-01-17 17 24 18
AppKit doesn't allow to access CGI data, so I need to use a helper. Multiple times. Probably the better solution is to add NSImage method.

But even so, 10% of the rest conflicts is where you need to really spend time. I'll do a pull request as soon as I finish this and when I'll need to set up a new CI (CircleCI) and make it all work. I would mean a lot to me if you could test it after pull request is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants