Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct given style for the InteractiveSelectPrinter instead of the default theme. #426

Merged
merged 2 commits into from Dec 24, 2022

Conversation

sephiroth74
Copy link

Description

Use the correct given style style for the InteractiveSelectPrinter instead of the default theme.

Scope

What is affected by this pull request?

  • [ v] Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #

To-Do Checklist

  • [x ] I tested my changes
  • [ x] I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #426 (a331e6f) into master (45b7694) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   81.53%   81.52%   -0.01%     
==========================================
  Files          29       29              
  Lines        2101     2106       +5     
==========================================
+ Hits         1713     1717       +4     
- Misses        371      372       +1     
  Partials       17       17              
Impacted Files Coverage Δ
interactive_select_printer.go 52.73% <100.00%> (ø)
interactive_confirm_printer.go 91.04% <0.00%> (-0.90%) ⬇️
print.go 100.00% <0.00%> (ø)
interactive_continue_printer.go 83.82% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Thanks for contributing! 🚀

@MarvinJWendt MarvinJWendt changed the title Feature/option style [fix]: Use the correct given style style for the InteractiveSelectPrinter instead of the default theme. Dec 24, 2022
@MarvinJWendt MarvinJWendt changed the title [fix]: Use the correct given style style for the InteractiveSelectPrinter instead of the default theme. Use the correct given style style for the InteractiveSelectPrinter instead of the default theme. Dec 24, 2022
@MarvinJWendt MarvinJWendt changed the title Use the correct given style style for the InteractiveSelectPrinter instead of the default theme. Use the correct given style for the InteractiveSelectPrinter instead of the default theme. Dec 24, 2022
@MarvinJWendt MarvinJWendt merged commit cd598d2 into pterm:master Dec 24, 2022
@sephiroth74 sephiroth74 deleted the feature/option_style branch December 24, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants