Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index out of range in InteractiveMultiselectPrinter #393

Merged
merged 1 commit into from Sep 1, 2022

Conversation

adombeck
Copy link
Contributor

Description

Fixes an index out of range bug in InteractiveMultiselectPrinter.

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #392

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #393 (d9e5425) into master (2e3f65c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   81.74%   81.70%   -0.05%     
==========================================
  Files          28       28              
  Lines        2016     2017       +1     
==========================================
  Hits         1648     1648              
- Misses        356      357       +1     
  Partials       12       12              
Impacted Files Coverage Δ
interactive_multiselect_printer.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch, and thanks for contributing 😄🚀

@MarvinJWendt MarvinJWendt merged commit 454a6f0 into pterm:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: index out of range in InteractiveMultiselectPrinter
2 participants