fix: the interactive confirm answers should match the confirm/reject text #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text Signed-off-by: Luis Davim <luis.davim@sendoso.com>
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 82.04% 82.05%
=======================================
Files 28 28
Lines 2005 2006 +1
=======================================
+ Hits 1645 1646 +1
Misses 348 348
Partials 12 12
Continue to review full report at Codecov.
|
luisdavim
force-pushed
the
confirm_answers
branch
from
98ab346
to
561cda9
Compare
MarvinJWendt
approved these changes
Jul 26, 2022
|
Hi @luisdavim, thanks for the PR! BTW: You can disable linting for specific lines: https://golangci-lint.run/usage/false-positives/#nolint-directive 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The lib allows specifying the confirmation and rejection text but hardcodes the answers to yes or no, this aims to fix that.
Fixing this issue helps with internationalisation, for example, in most Latin based languages the suffix should be
[s/N]instead of[y/N](in French it would probably be[o/N])Note: I've disabled the
gocriticcomplaint regardingpreferDecodeRuneas I don't think it would make sense to useutf8.DecodeRuneInStringin this situation.Ideally,
gocriticshould allow disabling the rule for a single line with a comment in the code, but that doesn't seem to be possible at the moment...Scope
Interactive Confirm Printer
To-Do Checklist