Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds InfoPrinter in SpinnerPrinter #380

Merged
merged 1 commit into from Jul 22, 2022

Conversation

orobardet
Copy link

@orobardet orobardet commented Jul 22, 2022

Description

In addition to Success/Warning/Failure message style in Spinner, this PR adds Info style.
For example, this allows to customize the new InfoPrinter with a "No change" printer, as a "no change" state is now common in idem potency systems.

Spinner example is update to:

pterm-info-spinner

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@orobardet
Copy link
Author

I changed the _examples/spinner/demo/main.go, but I don't know how to update the svg and all related README including examples code and their results. Is there a script?

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #380 (4c9ffb6) into master (86a935d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   81.98%   82.04%   +0.06%     
==========================================
  Files          28       28              
  Lines        1998     2005       +7     
==========================================
+ Hits         1638     1645       +7     
  Misses        348      348              
  Partials       12       12              
Impacted Files Coverage Δ
spinner_printer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a935d...4c9ffb6. Read the comment docs.

@MarvinJWendt
Copy link
Member

MarvinJWendt commented Jul 22, 2022

I changed the _examples/spinner/demo/main.go, but I don't know how to update the svg and all related README including examples code and their results. Is there a script?

This happens automatically when the PR is merged. No worries!

Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing 🥳

@MarvinJWendt MarvinJWendt self-assigned this Jul 22, 2022
@MarvinJWendt MarvinJWendt added proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future feature labels Jul 22, 2022
@MarvinJWendt MarvinJWendt merged commit d436318 into pterm:master Jul 22, 2022
@MarvinJWendt
Copy link
Member

I will release this PR as soon as the CI system succeeded. If not, feel free to ping me :)

@MarvinJWendt
Copy link
Member

Released in v0.12.44

@orobardet
Copy link
Author

Wow, that was fast! Thanks a lot for accepting this PR and releasing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants