New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds InfoPrinter in SpinnerPrinter #380
Adds InfoPrinter in SpinnerPrinter #380
Conversation
I changed the _examples/spinner/demo/main.go, but I don't know how to update the svg and all related README including examples code and their results. Is there a script? |
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 81.98% 82.04% +0.06%
==========================================
Files 28 28
Lines 1998 2005 +7
==========================================
+ Hits 1638 1645 +7
Misses 348 348
Partials 12 12
Continue to review full report at Codecov.
|
This happens automatically when the PR is merged. No worries! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for contributing 🥳
I will release this PR as soon as the CI system succeeded. If not, feel free to ping me :) |
Released in v0.12.44 |
Wow, that was fast! Thanks a lot for accepting this PR and releasing :) |
Description
In addition to Success/Warning/Failure message style in Spinner, this PR adds Info style.
For example, this allows to customize the new InfoPrinter with a "No change" printer, as a "no change" state is now common in idem potency systems.
Spinner example is update to:
Scope
Related Issue
Fixes #
To-Do Checklist