Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to add a timeout for InteractiveConfirm #543

Open
GuanTu opened this issue Jul 27, 2023 · 2 comments · May be fixed by #568
Open

Request to add a timeout for InteractiveConfirm #543

GuanTu opened this issue Jul 27, 2023 · 2 comments · May be fixed by #568
Labels
proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future

Comments

@GuanTu
Copy link

GuanTu commented Jul 27, 2023

Hi, Can InteractiveConfirm add a timeout field to continue execution with DefaultValue after waiting?
@GuanTu GuanTu added the proposal Proposal to add a new feature to pterm label Jul 27, 2023
@MarvinJWendt MarvinJWendt added the proposal-accepted Proposals which are accepted for implementation in the future label Jul 27, 2023
@MarvinJWendt
Copy link
Member

Sounds valid to me

@KarolosLykos KarolosLykos linked a pull request Aug 30, 2023 that will close this issue
Open
8 tasks
@KarolosLykos
Copy link
Contributor

@MarvinJWendt I've submitted a draft pull request that addresses the mentioned concern. Take a look and share your thoughts. If it aligns with your expectations, please guide me on how to proceed with adding examples for this new feature. Moreover, I believe this approach can be extended to enhance other interactive printers as well. Your feedback is greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Add timeout option to interactive confirm printer. KarolosLykos/pterm
3 participants
@KarolosLykos @GuanTu @MarvinJWendt