Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(spinner_printer): make spinner stop return itself #566

Closed
wants to merge 3 commits into from
Closed

refactor(spinner_printer): make spinner stop return itself #566

wants to merge 3 commits into from

Conversation

KarolosLykos
Copy link
Contributor

Description

Changed Spinner printer to return itself (*SpinnerPrinter and error) on Close method.

Scope

Spinner Printer

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #558

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #566 (59355c4) into master (7fea5c7) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   79.66%   79.66%           
=======================================
  Files          32       32           
  Lines        3625     3625           
=======================================
  Hits         2888     2888           
  Misses        680      680           
  Partials       57       57
Files Changed Coverage Δ
spinner_printer.go 95.23% <ø> (ø)

@MarvinJWendt MarvinJWendt added the breaking Something that would be considered as a breaking change label Aug 29, 2023
@MarvinJWendt
Copy link
Member

Hi @KarolosLykos, FYI: since this is a breaking issue, this PR will get merged with the next breaking release, which is v0.13.0, which could take a long time.

@MarvinJWendt MarvinJWendt changed the title rafactor(spinner_printer): make spinner stop return itself refactor(spinner_printer): make spinner stop return itself Aug 29, 2023
@MarvinJWendt
Copy link
Member

I am closing this for now, since this is a breaking change and we don't know when we will release the next breaking version.
When we release the next breaking version, we'll most likely work on another branch and then merge that one into master as soon as we're confident that the changes are alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinJWendt MarvinJWendt Awaiting requested review from MarvinJWendt MarvinJWendt is a code owner

Assignees
No one assigned
Labels
breaking Something that would be considered as a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make spinner.Stop return itself
2 participants
@KarolosLykos @MarvinJWendt