Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spinner.Stop return itself #558

Open
MarvinJWendt opened this issue Aug 20, 2023 · 0 comments
Open

Make spinner.Stop return itself #558

MarvinJWendt opened this issue Aug 20, 2023 · 0 comments
Labels
breaking Something that would be considered as a breaking change bug Something isn't working

Comments

@MarvinJWendt
Copy link
Member

spinner.Stop should return (*SpinnerPrinter, error), but it just returns error.
@MarvinJWendt MarvinJWendt added bug Something isn't working breaking Something that would be considered as a breaking change labels Aug 20, 2023
@KarolosLykos KarolosLykos mentioned this issue Aug 28, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Something that would be considered as a breaking change bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(spinner_printer): make spinner stop return itself KarolosLykos/pterm
1 participant
@MarvinJWendt