Data race on pterm.SpinnerPrinter

[KirillSerebryakov123]

Hello.

I have identified a data race on the pterm.SpinnerPrinter.

General information:

• pterm version: v0.12.57
• go version: v1.19.7
• os: windows

Steps to reproduce:
run following code with go run -race

p, err := pterm.DefaultSpinner.
    WithShowTimer(false).
    WithRemoveWhenDone(true).
    Start("Doing stuff...")

if err != nil {
    log.Fatalf("Start spinner failed: %s", err.Error())
}

time.Sleep(2 * time.Second)

err = p.Stop()
if err != nil {
    log.Fatalf("Stop spinner failed: %s", err.Error())
}

After inspecting the source code i have found out that the reason is the go routine, spawned in func (s SpinnerPrinter) Start(text ...interface{}) (*SpinnerPrinter, error)

pterm/spinner_printer.go

Line 127 in 971fa81

func (s SpinnerPrinter) Start(text ...interface{}) (*SpinnerPrinter, error) {

A new routine is being started within this method, which reads the IsActive field.

pterm/spinner_printer.go

Line 141 in 971fa81

for s.IsActive {

func (s *SpinnerPrinter) Stop() error writes to this field from anothe routine, and this causes a data race.

pterm/spinner_printer.go

Line 171 in 971fa81

s.IsActive = false

[MarvinJWendt]

Hi @KirillSerebryakov123, thanks for reporting! This should get fixed with #447 :)

[jsteenb2]

hey all, any update here?

I'm seeing the same issue running go 1.21 with the github.com/pterm/pterm@v0.12.79 module and seeing errors when go test is invoked with -race. I'm using the multiwriter, and it seems to be hitting the race conditions within the spinners that are created with it.