Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressbar count unreadable in light theme #446

Open
matbme opened this issue Jan 22, 2023 · 2 comments
Open

Progressbar count unreadable in light theme #446

matbme opened this issue Jan 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@matbme
Copy link

matbme commented Jan 22, 2023

Progressbar has LightWhite hard-coded for the progress count, which makes it impossible to read in terminals with light background.

Other colors such as the progress percentage also have a hard-coded RGB values. I believe they should instead use FgGreen and FgRed provided by the library.

Progress bar in dark background:
image

Progress bar in light background:
image

@matbme matbme added the bug Something isn't working label Jan 22, 2023
@MarvinJWendt
Copy link
Member

Progressbar has LightWhite hard-coded for the progress count, which makes it impossible to read in terminals with light background.

True, we never tested against light mode. We'll fix that.

Other colors such as the progress percentage also have a hard-coded RGB values. I believe they should instead use FgGreen and FgRed provided by the library.

For the percentage, it's a bit more difficult. The percentage is faded between red and green. This is only possible with RGB values.

@matbme
Copy link
Author

matbme commented Jan 22, 2023

This is only possible with RGB values.

Maybe instead of using pure red and pure green, something like #BC0000 for red and #00B200 for green would look good in both cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants