Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interactive_printers): change DefaultText to Label on InteractiveConfirm and InteractiveMultiselect #414

Closed
wants to merge 1 commit into from

Conversation

VictorAssunc
Copy link
Contributor

@VictorAssunc VictorAssunc commented Oct 8, 2022

Description

Changed DefaultText and TextStyle to Label and LabelStyle on InteractiveConfirm and InteractiveMultiselect. Deprecated methods with old names

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #405

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

…teractiveConfirm and InteractiveMultiselect
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #414 (44f089e) into master (9f77da7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   81.10%   81.14%   +0.03%     
==========================================
  Files          29       29              
  Lines        2101     2105       +4     
==========================================
+ Hits         1704     1708       +4     
  Misses        380      380              
  Partials       17       17              
Impacted Files Coverage Δ
interactive_confirm_printer.go 92.18% <100.00%> (+0.25%) ⬆️
interactive_continue_printer.go 84.28% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VictorAssunc
Copy link
Contributor Author

As I already said, if you can label with hacktoberfest-accepted when everything is ok, it would be nice :)

@MarvinJWendt MarvinJWendt added breaking Something that would be considered as a breaking change hacktoberfest-accepted labels Oct 9, 2022
@MarvinJWendt
Copy link
Member

I am closing this for now, since this is a breaking change and we don't know when we will release the next breaking version.
When we release the next breaking version, we'll most likely work on another branch and then merge that one into master as soon as we're confident that the changes are alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Something that would be considered as a breaking change hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultText should be Label in InteractiveConfirmPrinter and InteractiveContinuePrinter
2 participants