Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultText should be Label in InteractiveConfirmPrinter and InteractiveContinuePrinter #405

Open
MarvinJWendt opened this issue Sep 15, 2022 · 3 comments
Open

DefaultText should be Label in InteractiveConfirmPrinter and InteractiveContinuePrinter #405

MarvinJWendt opened this issue Sep 15, 2022 · 3 comments
Labels
breaking Something that would be considered as a breaking change proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future

Comments

@MarvinJWendt
Copy link
Member

DefaultText should be Label in InteractiveConfirmPrinter and InteractiveContinuePrinter.
The WithXxx methods should become deprecated and wrap the WithLabel ones.

Depends on: #384
@MarvinJWendt MarvinJWendt added bug Something isn't working breaking Something that would be considered as a breaking change proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future and removed bug Something isn't working labels Sep 15, 2022
@VictorAssunc
Copy link
Contributor

hi, can i work with this?

@MarvinJWendt
Copy link
Member Author

Hi @VictorAssunc, you could! But if you want it to count to Hacktoberfest, we will most likely not be able to merge it in October, as this issue is a breaking one and we will merge all breaking changes at the same time.

@VictorAssunc
Copy link
Contributor

it's okay, I think an approved PR on a repo with hacktoberfest label works. you can label PR with hacktoberfest-accepted too

@VictorAssunc VictorAssunc mentioned this issue Oct 8, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Something that would be considered as a breaking change proposal Proposal to add a new feature to pterm proposal-accepted Proposals which are accepted for implementation in the future
Projects
None yet
Milestone
No milestone
2 participants
@VictorAssunc @MarvinJWendt