Customizable multiselect printer #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 81.76% 81.25% -0.51%
==========================================
Files 29 29
Lines 2084 2097 +13
==========================================
Hits 1704 1704
- Misses 365 378 +13
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jochil
force-pushed
the
customizable-multiselect-printer
branch
from
9712ff3
to
b5668d5
Compare
|
Thanks for the PR! I'll take a look soon 👍 |
MarvinJWendt
requested changes
Sep 12, 2022
MarvinJWendt
requested changes
Sep 12, 2022
|
Hi @jochil, I have left some comments, the rest looks good! I'll merge it when you've fixed the comments 🚀 |
jochil
force-pushed
the
customizable-multiselect-printer
branch
3 times, most recently
from
8913607
to
69698cb
Compare
@MarvinJWendt Thanks for the feedback... I fixed the comments |
jochil
force-pushed
the
customizable-multiselect-printer
branch
from
69698cb
to
24d0594
Compare
|
@MarvinJWendt Hi. Is there something else I can adjust, please let me know :) |
|
Hi @jochil, sorry for the long wait, I will review it now :) |
MarvinJWendt
approved these changes
Oct 1, 2022
renovate bot
added a commit
to defenseunicorns/zarf
that referenced
this pull request
Oct 3, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | require | patch | `v0.12.47` -> `v0.12.48` | --- ### Release Notes <details> <summary>pterm/pterm</summary> ### [`v0.12.48`](https://togithub.com/pterm/pterm/releases/tag/v0.12.48) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.47...v0.12.48) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Exciting New Features 🎉 - Customizable multiselect printer by [@​jochil](https://togithub.com/jochil) in [pterm/pterm#402 **Full Changelog**: pterm/pterm@v0.12.47...v0.12.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Noxsios
pushed a commit
to defenseunicorns/zarf
that referenced
this pull request
Mar 8, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | require | patch | `v0.12.47` -> `v0.12.48` | --- ### Release Notes <details> <summary>pterm/pterm</summary> ### [`v0.12.48`](https://togithub.com/pterm/pterm/releases/tag/v0.12.48) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.47...v0.12.48) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Exciting New Features 🎉 - Customizable multiselect printer by [@​jochil](https://togithub.com/jochil) in [pterm/pterm#402 **Full Changelog**: pterm/pterm@v0.12.47...v0.12.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding options to the
InteractiveMultiselectPrinterto customize it:NoFilterto disable fuzzy search / filterKeySelectandKeyConfirmto use custom keys for selecting an item and confirm selectionScope
Related Issue
Fixes #
To-Do Checklist