Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textinput): fixed overwriting the default values #398

Merged

Conversation

MarvinJWendt
Copy link
Member

Fixes #387

@MarvinJWendt MarvinJWendt linked an issue Sep 4, 2022 that may be closed by this pull request
@github-actions github-actions bot added the fix label Sep 4, 2022
Copy link
Member

@floaust floaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Merging #398 (317f2bf) into master (63b9d9e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   81.70%   81.70%           
=======================================
  Files          28       28           
  Lines        2017     2017           
=======================================
  Hits         1648     1648           
  Misses        357      357           
  Partials       12       12           
Impacted Files Coverage Δ
interactive_textinput_printer.go 4.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MarvinJWendt MarvinJWendt merged commit 12bd74e into master Sep 4, 2022
@MarvinJWendt MarvinJWendt deleted the 387-user-input-reappears-with-interactivetextinput branch September 4, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User input reappears with InteractiveTextInput
2 participants