Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fixed column length calculation for Chinese strings #378

Merged
merged 1 commit into from Jul 17, 2022

Conversation

opsnull
Copy link
Contributor

@opsnull opsnull commented Jul 15, 2022

Description

fixed column length calculation for Chinese strings

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #377

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #378 (f8f2d26) into master (1109943) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files          28       28           
  Lines        1998     1998           
=======================================
  Hits         1638     1638           
  Misses        348      348           
  Partials       12       12           
Impacted Files Coverage Δ
table_printer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1109943...f8f2d26. Read the comment docs.

Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing 🥳

@MarvinJWendt MarvinJWendt merged commit f873e45 into pterm:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the table and header contain Chinese characters, the display results are not aligned
2 participants