Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spinner): fix line didn't clear properly #375

Conversation

floaust
Copy link
Member

@floaust floaust commented Jun 22, 2022

Description

Fix line didn't clear properly.

Scope

What is affected by this pull request?

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Related Issue

Fixes #374

To-Do Checklist

  • I tested my changes
  • I have commented every method that I created/changed
  • I updated the examples to fit with my changes
  • I have added tests for my newly created methods

@floaust floaust linked an issue Jun 22, 2022 that may be closed by this pull request
@github-actions github-actions bot added the fix label Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #375 (efba353) into master (8dc2bc1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   81.97%   81.98%           
=======================================
  Files          28       28           
  Lines        1997     1998    +1     
=======================================
+ Hits         1637     1638    +1     
  Misses        348      348           
  Partials       12       12           
Impacted Files Coverage Δ
spinner_printer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc2bc1...efba353. Read the comment docs.

@floaust floaust self-assigned this Jun 22, 2022
Copy link
Member

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarvinJWendt MarvinJWendt merged commit 9d221f1 into master Jun 22, 2022
@MarvinJWendt MarvinJWendt deleted the 374-spinner-doesnt-clean-output-area-when-printing-short-timestamps branch June 22, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinner doesn't clean output area when printing short timestamps
2 participants