Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependency with chardet>=3.0.2,<6 #6179

Merged
merged 1 commit into from Jun 28, 2022

Conversation

hswong3i
Copy link
Contributor

https://github.com/chardet/chardet/releases/tag/5.0.0 was released on 2022-06-25 with remove of Python 3.6 support, which also align with our Python > 3.6 requirement.

Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com

@nateprewitt
Copy link
Member

Thanks for the PR, @hswong3i. We’ll also need an update in the __init__.py for the version range. You can find an example here.

We’ll also need to do some quick manual regression testing to verify there isn’t anything substantially breaking in the major version.

https://github.com/chardet/chardet/releases/tag/5.0.0 was released on
2022-06-25 with remove of Python 3.6 support, which also align with our
Python > 3.6 requirement.

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@hswong3i
Copy link
Contributor Author

Thanks for the PR, @hswong3i. We’ll also need an update in the init.py for the version range. You can find an example here.

@nateprewitt thank you for your prompt reply, and I had also discover this when running GitLab CLI.

We’ll also need to do some quick manual regression testing to verify there isn’t anything substantially breaking in the major version.

As your reference, https://github.com/python-gitlab/python-gitlab/blob/main/setup.py using request, and I got following message before apply this PR:

/usr/lib/python3/dist-packages/requests/__init__.py:109: RequestsDependencyWarning: urllib3 (1.26.9) or c
hardet (5.0.0)/charset_normalizer (2.1.0) doesn't match a supported version!
  warnings.warn(

Now my re-packaged https://build.opensuse.org/package/show/home:alvistack/psf-requests-2.28.0 working fine with https://build.opensuse.org/package/show/home:alvistack/python-gitlab-python-gitlab-3.5.0 under Ubuntu 22.04 with Python 3.10.

@hswong3i
Copy link
Contributor Author

Result after running make and make ci: report.xml.txt

================================================ short test summary info =================================================
FAILED tests/test_requests.py::TestTimeout::test_connect_timeout[timeout0] - Failed: The connect() request should time ...
FAILED tests/test_requests.py::TestTimeout::test_connect_timeout[timeout1] - Failed: The connect() request should time ...
FAILED tests/test_requests.py::TestTimeout::test_total_timeout_connect[timeout0] - requests.exceptions.ReadTimeout: HTT...
FAILED tests/test_requests.py::TestTimeout::test_total_timeout_connect[timeout1] - requests.exceptions.ReadTimeout: HTT...
===================== 4 failed, 575 passed, 13 skipped, 1 xfailed, 24 warnings in 172.28s (0:02:52) ======================
make: *** [Makefile:8: ci] Error 1

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through some checks locally and our previous test benchmarks seem to match between the two. I think we can raise the version range here comfortably.

@nateprewitt nateprewitt merged commit 73793ce into psf:main Jun 28, 2022
@hswong3i hswong3i deleted the chardet_lt_6 branch June 28, 2022 06:29
@nateprewitt nateprewitt mentioned this pull request Jun 29, 2022
@hswong3i hswong3i restored the chardet_lt_6 branch July 18, 2022 06:40
giordano added a commit to giordano/reframe that referenced this pull request Aug 26, 2022
This makes `requests` compatible with `chardet` v5: psf/requests#6179
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Dec 12, 2022
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request May 22, 2023
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 8, 2023
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 9, 2023
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 10, 2023
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 10, 2023
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i added a commit to alvistack/psf-requests that referenced this pull request Jul 10, 2023
    git clean -xdf
    tar zcvf ../python-requests_2.27.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp python-requests.spec ../python-requests_2.27.1-1.spec
    mv ../python*-requests*2.27.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.27.1
    rm -rf ../python*-requests_2.27.1*.*

See psf#6179

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants