Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth parsing for proxies #6028

Merged
merged 1 commit into from Jan 4, 2022
Merged

Conversation

nateprewitt
Copy link
Member

@nateprewitt nateprewitt commented Jan 4, 2022

Thanks to @adamp01 and @racam for quickly helping us find this. Moving from urlparse to parse_url has led to Requests dropping the auth portion of proxy URLs. This patch will manually add it if present, returning us to our previous behavior.

This closes #6027.

Co-authored-by: adamp01 <@adamp01>
@sigmavirus24 sigmavirus24 merged commit 8fa9724 into psf:main Jan 4, 2022
@nateprewitt nateprewitt deleted the prox_auth_fix branch January 4, 2022 16:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy authentication bug
2 participants