Appropriately handle urllib3's InvalidHeader exception #5914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
force-pushed
the
invalid_header
branch
from
ba100ec
to
769ac18
Compare
sigmavirus24
approved these changes
Aug 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4306 raised an issue in our initial integration with urllib3's InvalidHeader implementation. We've been leaking an unwrapped exception in some occasions through our HTTPAdapter. This patch should consolidate to the single Requests exception in all cases.
This may technically be considered breaking as we're changing the exception type, but Requests
InvalidHeaderwas already raised through this API in the common case, so I would consider this as more of a bug.