Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old Dependencies #5719

Closed
gtoph opened this issue Jan 15, 2021 · 2 comments
Closed

Old Dependencies #5719

gtoph opened this issue Jan 15, 2021 · 2 comments

Comments

@gtoph
Copy link

gtoph commented Jan 15, 2021

Just wondering why the dependencies haven't been updated for a while now. Seems to be requiring a pretty old version of IDNA

requests 2.25.1 requires idna<3,>=2.5

Ran it with the latest 3.1 and still seems to work fine. Wonder if the older version is a real requirement?
@nateprewitt
Copy link
Member

Hi @gtoph,

idna 3.0 was only released 2 weeks ago. We've restricted version caps at major version bumps to avoid pulling in breaking API changes without testing. There's currently a PR (#5711) open discussing this, so we'll close this in favor of that. Thanks.

@gtoph
Copy link
Author

gtoph commented Jan 15, 2021

No worries, it's just my ocd to have the latest versions ;)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nateprewitt @gtoph